feat: add Orgo provider#458
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 6, 2026, 10:28 AM ET / 14:28 UTC. Summary Reproducibility: yes. for the blocking review findings: source inspection shows raw Orgo HTTP error bodies are returned and remote creates happen before any durable claim or recovery record. The live provider behavior itself is not yet reproduced because no hosted Orgo credentials are available. Review metrics: 2 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review findings
Review detailsBest possible solution: Land Orgo only after HTTP error redaction, a durable remote-create recovery and cleanup contract, and redacted hosted create/run/delete proof are all in place. Do we have a high-confidence way to reproduce the issue? Yes for the blocking review findings: source inspection shows raw Orgo HTTP error bodies are returned and remote creates happen before any durable claim or recovery record. The live provider behavior itself is not yet reproduced because no hosted Orgo credentials are available. Is this the best way to solve the issue? No; the implementation direction is plausible, but it is not merge-ready until the redaction bug, durable recovery contract, and hosted lifecycle proof are resolved. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against cd9ede0bd461. Label changesLabel justifications:
Evidence reviewedSecurity concerns:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (4 earlier review cycles)
|
d9aab2f to
482bc1b
Compare
8f551f1 to
6709b30
Compare
6709b30 to
7e56248
Compare
|
@clawsweeper re-review Rebased onto current main and fixed the review findings: provider and live-smoke readiness polling now wait for running state, terminal startup failures clean up resources, and provider capabilities satisfy current registry conformance. Exact head: |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
@clawsweeper re-review |
7e56248 to
5c9ff32
Compare
|
@clawsweeper re-review Updated #458 to current Validation now completed:
I am not merging this yet while |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
@clawsweeper re-review Pushed maintainer fixes for the concrete security/release findings. Head: Changes made:
Local validation passed on this head: Still not merging: hosted Orgo lifecycle proof remains blocked on paid-plan authorization, and |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Public CI is now green on current head Still not merging: hosted Orgo lifecycle proof remains blocked on paid-plan authorization, and |
|
@clawsweeper re-review Updated the PR body with the canonical summary, validation evidence, and remaining merge gate for current head. No code changes in this update. Still not merging unless the live proof labels clear and the provider-specific proof/contract gate is satisfied. |
3de3cb8 to
a13a41a
Compare
|
@clawsweeper re-review Rebased Orgo onto current Head: Change made:
Local validation passed: Public CI is green on this head: https://github.com/openclaw/crabbox/actions/runs/28103708184 Still not merging: hosted Orgo lifecycle proof remains blocked on paid-plan authorization, and |
|
🦞🧹 I asked ClawSweeper to review this item again. |
a13a41a to
8cb00c2
Compare
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
@clawsweeper re-review Updated the PR body to current head No code changes in this update. The remaining gate is still hosted Orgo lifecycle proof with real credentials; there are no Orgo API credentials in this environment. |
|
@clawsweeper re-review Current head Additional local reproduction while checking the earlier pending jobs:
Still not merging: hosted Orgo lifecycle proof remains blocked by missing real Orgo credentials, and |
8cb00c2 to
23b6847
Compare
|
🦞🧹 I asked ClawSweeper to review this item again. |
Drives the real *orgoHTTPClient through the delegated-run backend against a fake Orgo REST API (httptest), covering the full lifecycle: create workspace, create computer, run bash, delete computer, delete workspace. Asserts the Bearer auth header, exit code, SyncDelegated, stdout, and that every expected API endpoint is hit. No real secrets: the API key is a dummy value via CRABBOX_ORGO_API_KEY and the base URL is the in-process test server via CRABBOX_ORGO_API_BASE, so the test never reaches the live Orgo API. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
23b6847 to
7bc64fd
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
|
@clawsweeper re-review Updated #458 to current Changes made:
Validation passed: Validation note: passed the Orgo/provider packages and Still not merging: hosted Orgo lifecycle proof remains blocked here because |
|
🦞🧹 I asked ClawSweeper to review this item again. |
Summary
Adds a delegated-run Orgo provider for Linux cloud computers.
provider: orgowith aliasorgo-ai.--no-sync.Maintainer hardening
success: trueand the expected marker.Verification
Exact candidate:
7bc64fd2b085869a3d132ee13655261e44972b9dgo test -race ./internal/providers/orgo -count=1go test -race ./internal/cli -run '^TestControllerGetReconcilesProviderExpiry$' -count=10go vet ./...go test -race ./internal/providers/orgo ./internal/providers/all ./internal/cli -run 'Orgo|orgo|TestController(GetReconcilesProviderExpiry|RestartDoesNotReacquireMissingKnownLease)' -count=1node --test scripts/live-smoke.test.js(59/59)bash -n scripts/live-smoke.shnode scripts/build-docs-site.mjsgo build -trimpath -o bin/crabbox ./cmd/crabboxRemaining live gate
Do not merge yet.
CRABBOX_LIVE=1 CRABBOX_LIVE_PROVIDERS=orgo scripts/live-smoke.shis ready to prove create, command execution, and successful resource deletion on this exact candidate, but no Orgo credential is currently available for the canary.